[Tarantool-patches] [PATCH v6 1/5] build, lua: built-in module datetime

[Vladislav Shpilevoy]

>> +local function datetime_tostring(o)
>> +    if ffi.typeof(o) == datetime_t then
>> +        local sz = 48
>> +        local buff = ffi.new('char[?]', sz)
> 
> I think we've agreed that the buffer used for formatting should be
> global.

If you are going with a global buffer, please, take into
account Lua GC and tickets 5632, 6050, 6259. If there is
going to be a global buffer, it must be properly shared. For
example, using buffer.ffi_stash_new(). See it source and
usages to find what that is.