[Tarantool-patches] [PATCH v3] net.box: allow to store user-defined fields in future object

Vitaliia Ioffe v.ioffe at tarantool.org
Mon Aug 16 14:32:02 MSK 2021


Hi all, 
 
QA LGTM
 
--
Vitaliia Ioffe
 
  
>Понедельник, 16 августа 2021, 12:20 +03:00 от Igor Munkin via Tarantool-patches <tarantool-patches at dev.tarantool.org>:
> 
>Vova,
>
>Thanks for the fixes!
>
>On 16.08.21, Vladimir Davydov wrote:
>> On Sat, Aug 14, 2021 at 02:17:00PM +0300, Igor Munkin wrote:
>> > On 13.08.21, Vladimir Davydov wrote:
>
><snipped>
>
>> > > +future.abc = nil
>> > > +---
>> > > +...
>> > > +future.abc -- nil
>> > > +---
>> > > +- null
>> > > +...
>> > > +future.abc = nil
>> >
>> > Looks like a typo: future.abc already equals to nil above.
>>
>> It's actually not a typo. I wanted to ensure that deleting a key that
>> has no value works fine. Added clarifying comments.
>
>Now I get it, thanks! Feel free to proceed with the patch then.
>
>> --
>
><snipped>
>
>--
>Best regards,
>IM
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20210816/de4a8d31/attachment.htm>


More information about the Tarantool-patches mailing list