[Tarantool-patches] [PATCH] replication: fix flaky gh-3055-election-promote test

Kirill Yukhin kyukhin at tarantool.org
Thu Aug 12 13:58:19 MSK 2021


Hello,

On 09 авг 10:42, Serge Petrenko via Tarantool-patches wrote:
> Found the following error in our CI:
> 
> [001] Test failed! Result content mismatch:
> [001] --- replication/gh-3055-election-promote.result	Mon Aug  2 17:52:55 2021
> [001] +++ var/rejects/replication/gh-3055-election-promote.reject	Mon Aug  9 10:29:34 2021
> [001] @@ -88,7 +88,7 @@
> [001]   | ...
> [001]  assert(not box.info.ro)
> [001]   | ---
> [001] - | - true
> [001] + | - error: assertion failed!
> [001]   | ...
> [001]  assert(box.info.election.term > term)
> [001]   | ---
> [001]
> 
> The problem was the same as in recently fixed election_qsync.test
> (commit 096a0a7d5e2442656d228658f89f0c7066c60b16): PROMOTE is written to
> WAL asynchronously, and box.ctl.promote() returns earlier than this
> happens.
> 
> Fix the issue by waiting for the instance to become writeable.
> 
> Follow-up #6034

I've checked your patch into 2.7, 2.8 and master.

--
Regards, Kirill Yukhin


More information about the Tarantool-patches mailing list