[Tarantool-patches] [PATCH 1/4] fiber: rename ref to fiber_ref
olegrok at tarantool.org
olegrok at tarantool.org
Wed Aug 11 23:33:28 MSK 2021
From: Oleg Babin <babinoleg at mail.ru>
Ref is a lua reference to fiber storage. This patch just renames
storage.lua.ref to storage_ref to underline that it's not a
reference to fiber itself and needed only for fiber storage.
---
src/lib/core/fiber.h | 2 +-
src/lua/fiber.c | 10 +++++-----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/lib/core/fiber.h b/src/lib/core/fiber.h
index b85625ba7..593847df7 100644
--- a/src/lib/core/fiber.h
+++ b/src/lib/core/fiber.h
@@ -626,7 +626,7 @@ struct fiber {
/**
* Optional fiber.storage Lua reference.
*/
- int ref;
+ int storage_ref;
} lua;
/**
* Iproto sync.
diff --git a/src/lua/fiber.c b/src/lua/fiber.c
index 38394666b..83dcbe2fa 100644
--- a/src/lua/fiber.c
+++ b/src/lua/fiber.c
@@ -670,7 +670,7 @@ lbox_fiber_name(struct lua_State *L)
/**
* Trigger invoked when the fiber has stopped execution of its
- * current request. Only purpose - delete storage.lua.ref keeping
+ * current request. Only purpose - delete storage.lua.storage_ref keeping
* a reference of Lua fiber.storage object. Unlike Lua stack,
* Lua fiber storage may be created not only for fibers born from
* Lua land. For example, an IProto request may execute a Lua
@@ -681,10 +681,10 @@ static int
lbox_fiber_on_stop(struct trigger *trigger, void *event)
{
struct fiber *f = (struct fiber *) event;
- int storage_ref = f->storage.lua.ref;
+ int storage_ref = f->storage.lua.storage_ref;
assert(storage_ref > 0);
luaL_unref(tarantool_L, LUA_REGISTRYINDEX, storage_ref);
- f->storage.lua.ref = LUA_NOREF;
+ f->storage.lua.storage_ref = LUA_NOREF;
trigger_clear(trigger);
free(trigger);
return 0;
@@ -694,7 +694,7 @@ static int
lbox_fiber_storage(struct lua_State *L)
{
struct fiber *f = lbox_checkfiber(L, 1);
- int storage_ref = f->storage.lua.ref;
+ int storage_ref = f->storage.lua.storage_ref;
if (storage_ref <= 0) {
struct trigger *t = (struct trigger *)
malloc(sizeof(*t));
@@ -706,7 +706,7 @@ lbox_fiber_storage(struct lua_State *L)
trigger_add(&f->on_stop, t);
lua_newtable(L); /* create local storage on demand */
storage_ref = luaL_ref(L, LUA_REGISTRYINDEX);
- f->storage.lua.ref = storage_ref;
+ f->storage.lua.storage_ref = storage_ref;
}
lua_rawgeti(L, LUA_REGISTRYINDEX, storage_ref);
return 1;
--
2.32.0
More information about the Tarantool-patches
mailing list