[Tarantool-patches] [PATCH luajit] ARM64: Fix write barrier in BC_USETS.
imun at tarantool.org
Wed Aug 11 10:22:05 MSK 2021
I've checked the patch into tarantool branch in tarantool/luajit and
bumped a new version in master.
On 07.07.21, Sergey Kaplun wrote:
> From: Mike Pall <mike>
> Contributed by Javier Guerra Giraldez.
> (cherry picked from commit c785131ca5a6d24adc519e5e0bf1b69b671d912f)
> Closed upvalues are never gray. So after closed upvalue is marked, it is
> marked as black. Black objects can't refer white objects, so for storing
> a white value in closed upvalue, we need to move the barrier forward and
> color our value to gray by using `lj_gc_barrieruv()`. This function
> can't be called on closed upvalues with non-white values (at least there
> is no need to mark it again).
> USETS bytecode for arm64 architecture has the incorrect instruction to
> check that upvalue is closed:
> | ccmp TMP0w, #0, #0, ne
> | beq <1 // branch out from barrier movement
> `TMP0w` contains `upvalue->closed` field. If it equals NULL (the first
> `#0`). The second zero is the value of NZCV condition flags set if the
> condition (`ne`) is FALSE . If the set value is not white, then
> flags are set to zero and branch is not taken (no Zero flag). If it
> happens at propagate or atomic GC State and the `lj_gc_barrieruv()`
> function is called then the gray value to set is marked as white. That
> leads to the assertion failure in the `gc_mark()` function.
> This patch changes yielded NZCV condition flag to 4 (Zero flag is up) to
> take the correct branch after `ccmp` instruction.
> Sergey Kaplun:
> * added the description and the test for the problem
> : https://developer.arm.com/documentation/dui0801/g/pge1427897656225
> : https://community.arm.com/developer/ip-products/processors/b/processors-ip-blog/posts/condition-codes-1-condition-flags-and-codes
> LuaJIT branch: https://github.com/tarantool/luajit/tree/skaplun/lj-426-incorrect-check-closed-uv
> Tarantool branch: https://github.com/tarantool/tarantool/tree/skaplun/lj-426-incorrect-check-closed-uv
> Assertion failure  is not related to the patch (I've reproduced it on
> master branch). Looks like another one GC64 issue.
> How to reproduce:
> 1) Run the following command from the Tarantool repo on Odroid:
> | $ i=0; while [[ $? == 0 ]]; do i=$(($i+1)); echo $i; make LuaJIT-tests; done
> 2) Wait (need 4-15 iterations).
> : https://github.com/tarantool/tarantool/runs/3009273464#step:4:4013
> Side note: Thanks to the Lord, that there is no #0 issue and it is not
> mentioned that way...
> src/vm_arm64.dasc | 2 +-
> ...6-arm64-incorrect-check-closed-uv.test.lua | 38 +++++++++++++++++++
> 2 files changed, 39 insertions(+), 1 deletion(-)
> create mode 100644 test/tarantool-tests/lj-426-arm64-incorrect-check-closed-uv.test.lua
More information about the Tarantool-patches