[Tarantool-patches] [PATCH 2/7] salad: fix segfault in case when mhash table allocation failure

Vladimir Davydov vdavydov at tarantool.org
Fri Aug 6 11:33:41 MSK 2021


On Thu, Aug 05, 2021 at 09:17:40PM +0300, mechanik20051988 wrote:
> From: mechanik20051988 <mechanik20.05.1988 at gmail.com>
> 
> There was no check for successful memory allocation in `new` and `clear`
> functions for mhash table. And if the memory was not allocated, a null
> pointer dereference occured.
> ---
>  src/lib/salad/mhash.h  | 99 +++++++++++++++++++++++++++---------------
>  test/unit/mhash_body.c |  4 +-
>  2 files changed, 66 insertions(+), 37 deletions(-)

LGTM

( But as I said before, I don't think we should have bothered )


More information about the Tarantool-patches mailing list