[Tarantool-patches] [PATCH v10 0/4] limbo: implement packets filtering

[Vladislav Shpilevoy]

Hi! Thanks for the patchset!

On top of the branch I tried the test I pasted in the
ticket's description.

I see the connection now breaks in one direction. But the
new leader still follows the old leader somewhy.

This is the old leader (id = 1) which did ROLLBACK:

tarantool> box.info.replication
---
- 1:
    id: 1
    uuid: bf51f188-cb5d-4471-85ee-2a2be4f24052
    lsn: 8
  2:
    id: 2
    uuid: ff1d81af-fae2-4e29-989a-4eb20f06eeb5
    lsn: 0
    upstream:
      peer: localhost:3314
      lag: 4.9944338798523
      status: stopped
      idle: 10.290937999991
      message: Replication does not support forward promote LSN (empty limbo, split
        brain)
    downstream:
      status: follow
      idle: 0.65130299999146
      vclock: {2: 1, 1: 8}
      lag: 14.389625072479
...

This is the new leader (id = 2) which did PROMOTE on the same data:

tarantool> box.info.replication
---
- 1:
    id: 1
    uuid: bf51f188-cb5d-4471-85ee-2a2be4f24052
    lsn: 8
    upstream:
      status: follow
      idle: 0.46603999999934
      peer: localhost:3313
      lag: 0.00013971328735352
    downstream:
      status: stopped
      message: unexpected EOF when reading from socket, called on fd 18, aka [::1]:3314
      system_message: Broken pipe
  2:
    id: 2
    uuid: ff1d81af-fae2-4e29-989a-4eb20f06eeb5
    lsn: 1
...

Why is there still downstream from id 1 to id 2? The new leader
should have received the ROLLBACK which it should have seen can't
be properly applied. Why didn't it cut the connection?