[Tarantool-patches] [PATCH v2 1/6] sql: introduce sql_func_flags()

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Fri Aug 6 01:14:45 MSK 2021


Hi! Thanks for the patch!

> diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h
> index 115c52f96..97b7a2401 100644
> --- a/src/box/sql/sqlInt.h
> +++ b/src/box/sql/sqlInt.h
> @@ -1186,6 +1186,8 @@ struct type_def {
>   *     SQL_FUNC_LENGTH    ==  OPFLAG_LENGTHARG
>   *     SQL_FUNC_TYPEOF    ==  OPFLAG_TYPEOFARG
>   */
> +/** Function is one of aggregate functions. */
> +#define SQL_FUNC_AGG		0x0001

The value is misaligned with the values below. They are using
whitespaces, so this new line probably also should use them.

>  #define SQL_FUNC_LIKE     0x0004	/* Candidate for the LIKE optimization */
>  #define SQL_FUNC_NEEDCOLL 0x0020	/* sqlGetFuncCollSeq() might be called.


More information about the Tarantool-patches mailing list