[Tarantool-patches] [PATCH v3 1/9] build: add Christian Hansen c-dt to the build

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Aug 5 02:58:21 MSK 2021

Hi! Thanks for the patch!

On 02.08.2021 02:40, Timur Safin via Tarantool-patches wrote:
> * Integrated chansen/c-dt parser as 3rd party module to the
>   Tarantool cmake build process.
> * Points to tsafin/c-dt instead iof original chansen/c-dt to
>   have easier build integration, because there is additional
>   commit which integrated cmake support

As I said in the previous review, it points at
https://github.com/tarantool/c-dt.git, not at tsafin/c-dt. Why
do you keep saying the contrary? Look:

	url = https://github.com/tarantool/c-dt.git

It is 'tarantool', not 'tsafin' here.

Also, like on the previous review, when I call 'make' and do
'git status', I see:

	Changes not staged for commit:
	  (use "git add <file>..." to update what will be committed)
	  (use "git restore <file>..." to discard changes in working directory)
	  (commit or discard the untracked or modified content in submodules)
		modified:   third_party/c-dt (modified content, untracked content)

You still didn't fix it. Please, do.

More information about the Tarantool-patches mailing list