[Tarantool-patches] [PATCH resend v2 02/11] lua: built-in module datetime

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Aug 5 02:57:58 MSK 2021

>>> : > +local datetime_mt = {
>>> : > +    -- __tostring = datetime_tostring,
>>> :
>>> : 16. Why is it commented out? Is it even tested then?
>>> It's implemented in the later patch in patchset series.
>> Well, then it should not be here in this commit.
>>> : > +    microseconds = function(self)
>>> : > +        return tonumber(self.secs*1e6 + self.nsec*1e3)
>>> :
>>> : 18. Please, add whitespaces around binary operators.
>>> Done! It was already such in the later commits which were part
>>> of in patchset. [Yes, apparently I need to squash few more commits,
>>> as Oleg Babin has asked elsewhere]
>> It is not just about squashes. It is only about atomicity (and
>> as a consequence - review simplicity). You can't just squash all
>> the commits into one. You will need to change the older commits
>> to make them right, then rebase the newer commits.
> I see.
> BTW, what is the simplest approach here you could recommend?
> I mean what tools do you use for shuffling code between version layers?
> How to make it simple enough and painless? (I'd love to see training 
> Here - I know how to do it the harder way in interactive rebase, but
> I suspect there are some helpers, which I missed, which allow to 
> Make it easy way. If any?)

My main tools for doing review fixes per-commit are:
'git rebase -i', 'git commit --amend', 'git add -u'.

I couldn't find anything easier. These commands take a couple of
seconds to print and I doubt there is any tool doing it faster.

More information about the Tarantool-patches mailing list