[Tarantool-patches] [PATCH v1 7/7] sql: remove unused MEM cast functions

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Aug 5 01:27:41 MSK 2021


Thanks for the patch!

> diff --git a/src/box/sql/vdbeaux.c b/src/box/sql/vdbeaux.c
> index 4a1fdb637..fc06e502e 100644
> --- a/src/box/sql/vdbeaux.c
> +++ b/src/box/sql/vdbeaux.c
> @@ -2323,17 +2323,15 @@ sqlVdbeDb(Vdbe * v)
>   * The returned value must be freed by the caller using sqlValueFree().
>   */
>  sql_value *
> -sqlVdbeGetBoundValue(Vdbe * v, int iVar, u8 aff)
> +sqlVdbeGetBoundValue(Vdbe * v, int iVar)

1. No need for a whitespace after *.

>  {
>  	assert(iVar > 0);
>  	if (v) {
>  		Mem *pMem = &v->aVar[iVar - 1];
>  		if (!mem_is_null(pMem)) {
>  			sql_value *pRet = sqlValueNew(v->db);
> -			if (pRet) {
> +			if (pRet)

2. != NULL.


More information about the Tarantool-patches mailing list