[Tarantool-patches] [PATCH v1 5/7] sql: remove implicit cast from OP_MakeRecord

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Aug 5 01:27:20 MSK 2021


Thanks for the patch!

On 28.07.2021 22:51, imeevma at tarantool.org wrote:
> This patch removes deprecated implicit cast from OP_MakeRecord opcode.
> Not there will be no implicit cast in OP_MakeRecord opcode.

1. Not -> Note? The commit seems strange. You basically said the same
thing 3 times: 1 in th title and 2 in the message.

> diff --git a/changelogs/unreleased/gh-4230-implicit-cast-for-comparison.md b/changelogs/unreleased/gh-4230-implicit-cast-for-comparison.md
> new file mode 100644
> index 000000000..9f523d3ed
> --- /dev/null
> +++ b/changelogs/unreleased/gh-4230-implicit-cast-for-comparison.md
> @@ -0,0 +1,3 @@
> +## feature/sql
> +
> +* Implicit cast for comparison now works according to defined rules (gh-4230).

2. Please, try to be more specific here. Users won't understand anything from
this sentence.


More information about the Tarantool-patches mailing list