[Tarantool-patches] [PATCH 11/20] net.box: rewrite response decoder in C

Vladimir Davydov vdavydov at tarantool.org
Mon Aug 2 10:36:49 MSK 2021


On Sat, Jul 31, 2021 at 12:12:51AM +0200, Vladislav Shpilevoy wrote:
> Thanks for the fixes!
> 
> > diff --git a/src/box/lua/net_box.c b/src/box/lua/net_box.c
> > index 2d2562550752..ac9052de286c 100644
> > --- a/src/box/lua/net_box.c
> > +++ b/src/box/lua/net_box.c
> > @@ -664,7 +664,7 @@ netbox_encode_method(struct lua_State *L)
> >  	return 0;
> >  }
> >  
> > -/**
> > +/*
> 
> There is misunderstanding, sorry. As doxygen I meant only these
> '@a param desc' lines. The /** are a part of our code style, look:
> https://github.com/tarantool/tarantool/wiki/Code-review-procedure#code-style
> 
> All out-of-function comments use /** on the first line, all comments inside
> of functions use /* on the first line.
> 
> After your fix this - the commit LGTM.

Fixed and pushed to master.


More information about the Tarantool-patches mailing list