[Tarantool-patches] [PATCH 5/5] decimal: introduce and use lua_pushdecimalstr()

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sun Aug 1 18:04:18 MSK 2021


Thanks for the review!

>> diff --git a/test/app-tap/gh-5632-6050-6259-gc-buf-reuse.test.lua b/test/app-tap/gh-5632-6050-6259-gc-buf-reuse.test.lua
>> index f806ba6b7..45273ed9a 100755
>> --- a/test/app-tap/gh-5632-6050-6259-gc-buf-reuse.test.lua
>> +++ b/test/app-tap/gh-5632-6050-6259-gc-buf-reuse.test.lua
>> @@ -223,14 +224,50 @@ local function test_info_uuid(test)
>>     test:ok(is_success, 'info uuid in gc')
>> end
>>
>> +local function test_decimal(test)
>> +    test:plan(1)
>> +
>> +    local gc_count = 100
>> +    local iter_count = 1000
>> +    local is_success = true
>> +
>> +    local d1 = decimal.new(1111111111111111111)
>> +    local d2 = decimal.new(2222222222222222222)
>> +
>> +    local function decimal_to_str()
>> +        local str1 = tostring(d1)
>> +        local str2 = tostring(d2)
>> +        local str3 = tostring(d1)
>> +        local str4 = tostring(d2)
>> +        if str1 ~= str3 or str2 ~= str4 then
>> +            is_success = false
>> +            assert(false)
> 
> Same as previos patch with uuid. I refer to the
> https://www.tarantool.io/en/doc/latest/reference/reference_lua/tap/#tap-example <https://www.tarantool.io/en/doc/latest/reference/reference_lua/tap/#tap-example>
> perhaps I miss something?

The assert is dropped on the branch.


More information about the Tarantool-patches mailing list