[Tarantool-patches] [PATCH 2/5] info: use luaL_pushuuidstr() for box.info uuids

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sun Aug 1 18:03:47 MSK 2021


Hi! Thanks for the review!

>> diff --git a/test/app-tap/gh-5632-6050-gc-buf-reuse.test.lua b/test/app-tap/gh-5632-6050-6259-gc-buf-reuse.test.lua
>> similarity index 79%
>> rename from test/app-tap/gh-5632-6050-gc-buf-reuse.test.lua
>> rename to test/app-tap/gh-5632-6050-6259-gc-buf-reuse.test.lua
>> index bf7590a14..f806ba6b7 100755
>> --- a/	
>> +++ b/test/app-tap/gh-5632-6050-6259-gc-buf-reuse.test.lua
>> @@ -190,11 +190,47 @@ local function test_json(test)
>>    test:ok(is_success, 'json in gc')
>> end
>>
>> -local test = tap.test('gh-5632-6050-gc-buf-reuse')
>> -test:plan(4)
>> +local function test_info_uuid(test)
>> +    test:plan(1)
>> +
>> +    local gc_count = 100
>> +    local iter_count = 1000
>> +    local is_success = true
>> +
>> +    local function uuid_to_str()
>> +        local uu = uuid.new()
>> +        local str1 = box.info.uuid
>> +        local str2 = box.info.cluster.uuid
>> +        local str3 = box.info.uuid
>> +        local str4 = box.info.cluster.uuid
>> +        if str1 ~= str3 or str2 ~= str4 then
>> +            is_success = false
>> +            assert(false)
> 
> Why did you keep the assert? I believe there should be just a non-ok in test?

Dropped on the branch.


More information about the Tarantool-patches mailing list