[Tarantool-patches] [RFC v3 1/3] xrow: allow to pass timestamp via xrow_encode_vclock_timed helper
Cyrill Gorcunov
gorcunov at gmail.com
Fri Apr 30 18:39:38 MSK 2021
We will enhance applier writer with timestamp of last written row.
It is needed to detect downstream lag.
Part-of #5447
Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
---
src/box/xrow.c | 5 ++++-
src/box/xrow.h | 21 +++++++++++++++++++--
2 files changed, 23 insertions(+), 3 deletions(-)
diff --git a/src/box/xrow.c b/src/box/xrow.c
index 2e364cea5..46ae23a78 100644
--- a/src/box/xrow.c
+++ b/src/box/xrow.c
@@ -1643,7 +1643,9 @@ xrow_encode_join(struct xrow_header *row, const struct tt_uuid *instance_uuid)
}
int
-xrow_encode_vclock(struct xrow_header *row, const struct vclock *vclock)
+xrow_encode_vclock_timed(struct xrow_header *row,
+ const struct vclock *vclock,
+ double tm)
{
memset(row, 0, sizeof(*row));
@@ -1662,6 +1664,7 @@ xrow_encode_vclock(struct xrow_header *row, const struct vclock *vclock)
row->body[0].iov_base = buf;
row->body[0].iov_len = (data - buf);
row->bodycnt = 1;
+ row->tm = tm;
row->type = IPROTO_OK;
return 0;
}
diff --git a/src/box/xrow.h b/src/box/xrow.h
index b3c664be2..f48e64b83 100644
--- a/src/box/xrow.h
+++ b/src/box/xrow.h
@@ -495,6 +495,20 @@ xrow_decode_register(struct xrow_header *row, struct tt_uuid *instance_uuid,
NULL, NULL);
}
+/**
+ * Encode vector clock with timestamp.
+ * @param row[out] Row to encode into.
+ * @param vclock vector clock to encode.
+ * @param tm timestamp.
+ *
+ * @retval 0 Success.
+ * @retval -1 Memory error.
+ */
+int
+xrow_encode_vclock_timed(struct xrow_header *row,
+ const struct vclock *vclock,
+ double tm);
+
/**
* Encode end of stream command (a response to JOIN command).
* @param row[out] Row to encode into.
@@ -503,8 +517,11 @@ xrow_decode_register(struct xrow_header *row, struct tt_uuid *instance_uuid,
* @retval 0 Success.
* @retval -1 Memory error.
*/
-int
-xrow_encode_vclock(struct xrow_header *row, const struct vclock *vclock);
+static inline int
+xrow_encode_vclock(struct xrow_header *row, const struct vclock *vclock)
+{
+ return xrow_encode_vclock_timed(row, vclock, 0);
+}
/**
* Decode end of stream command (a response to JOIN command).
--
2.30.2
More information about the Tarantool-patches
mailing list