[Tarantool-patches] [PATCH] build: fix linker flags for executable on MacOS

Igor Munkin imun at tarantool.org
Wed Apr 28 16:17:08 MSK 2021


Nikita,

Thanks for your review!

On 28.04.21, Nikita Pettik wrote:
> On 28 Apr 01:46, Igor Munkin wrote:
> > This patch fixes inaccuracy in Tarantool build configuration introduced
> > by commit 07c83aab5c066ca75c149112b331b4dbb81b3f38 ('build: adjust
> > LuaJIT build system'). All those MacOS-related tweaks for __PAGEZERO
> > size and preferred load address for the bundle are necessary only for
> > builds with 32-bit GC area on 64-bit host. The only case fitting these
> > conditions is x86_64 with no LUAJIT_ENABLE_GC64. All other 64-bit builds
> > use 64-bit GC area unconditionally.
> > 
> > Part of #5983
> > Needed for #5629
> > Follows up #4862
> > 
> > Signed-off-by: Igor Munkin <imun at tarantool.org>
> > ---
> 
> LGTM

Added your tag:
| Reviewed-by: Nikita Pettik <korablev at tarantool.org>

> 

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list