[Tarantool-patches] [PATCH 1/3] wal: sanitize wal_mode

Serge Petrenko sergepetrenko at tarantool.org
Mon Apr 26 12:40:57 MSK 2021



25.04.2021 16:26, Cyrill Gorcunov пишет:
> On Sun, Apr 25, 2021 at 11:08:25AM +0300, Serge Petrenko wrote:
>>> +enum wal_mode {
>>> +	/**
>>> +	 * Do not write data at all.
>>> +	 */
>>> +	WAL_NONE,
>>> +
> ...
>> Thanks for the patch!
>>
>> I'd leave an explicit WAL_NONE = 0.
>> I didn't know that enums start at zero, TBH.
> Yeah, this is a part of language standart.
>
>> This would be more readable IMO.
> I'll make it so and force push. Thanks a huge for review, guys!

Thanks! Please, update the commit message:
"- there is no need to set WAN_NONE to 0 explicitly" is not true anymore.

LGTM.

-- 
Serge Petrenko



More information about the Tarantool-patches mailing list