[Tarantool-patches] [PATCH 4/4] txn_limbo: simplify txn_limbo_on_parameters_change

Cyrill Gorcunov gorcunov at gmail.com
Thu Apr 22 14:34:45 MSK 2021


There is no need to test @confirm_lsn since we're
continue the list traversing in any case.

I keep "continue" here to be consistent with other "if"s.

Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
---
 src/box/txn_limbo.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/box/txn_limbo.c b/src/box/txn_limbo.c
index 0ac8fff25..c07db3025 100644
--- a/src/box/txn_limbo.c
+++ b/src/box/txn_limbo.c
@@ -707,8 +707,7 @@ txn_limbo_on_parameters_change(struct txn_limbo *limbo)
 		assert(e->ack_count <= VCLOCK_MAX);
 		if (!txn_has_flag(e->txn, TXN_WAIT_ACK)) {
 			assert(e->lsn == -1);
-			if (confirm_lsn == -1)
-				continue;
+			continue;
 		} else if (e->ack_count < replication_synchro_quorum) {
 			continue;
 		} else {
-- 
2.30.2



More information about the Tarantool-patches mailing list