[Tarantool-patches] [PATCH v3 01/10] wal: enrich row's meta information with sync replication flags

[Vladislav Shpilevoy]

Good job on the patch!

See 3 comments below.

> diff --git a/src/box/journal.h b/src/box/journal.h
> index 76c70c19f..3ce9c869e 100644
> --- a/src/box/journal.h
> +++ b/src/box/journal.h
> @@ -63,6 +63,7 @@ struct journal_entry {
>  	 * A journal entry completion callback argument.
>  	 */
>  	void *complete_data;
> +	uint8_t opt_flags;

1. I propose to call them just flags. There is no a third value
like 'no flag'. They are either set or not, am I right? Also the
member is missing a comment. The most important thing to say -
these flags are only for the last row.

>  	/**
>  	 * Asynchronous write completion function.
>  	 */
> @@ -97,6 +98,7 @@ journal_entry_create(struct journal_entry *entry, size_t n_rows,
>  	entry->approx_len	= approx_len;
>  	entry->n_rows		= n_rows;
>  	entry->res		= -1;
> +	entry->opt_flags	= 0;

2. You could initialize it with IPROTO_FLAG_COMMIT right here and
drop (*row)->is_commit = true from wal_assign_lsn. But this one up
to you. Maybe it is not a good idea.

>  }
>  
>  /**
> diff --git a/src/box/wal.c b/src/box/wal.c
> index 34af0bda6..4ec8034a3 100644
> --- a/src/box/wal.c
> +++ b/src/box/wal.c
> @@ -962,14 +962,14 @@ out:
>   */
>  static void
>  wal_assign_lsn(struct vclock *vclock_diff, struct vclock *base,
> -	       struct xrow_header **row,
> -	       struct xrow_header **end)
> +	       struct journal_entry *entry)

3. This part could be a separate commit, otherwise it is hard to
see the functional changes. Up to you if you want to split.

>  {
>  	int64_t tsn = 0;
> -	struct xrow_header **start = row;
> -	struct xrow_header **first_glob_row = row;
> +	struct xrow_header **start = entry->rows;
> +	struct xrow_header **end = entry->rows + entry->n_rows;
> +	struct xrow_header **first_glob_row = entry->rows;
>  	/** Assign LSN to all local rows. */
> -	for ( ; row < end; row++) {
> +	for (struct xrow_header **row = start; row < end; row++) {
>  		if ((*row)->replica_id == 0) {
>  			/*
>  			 * All rows representing local space data