[Tarantool-patches] [PATCH v5 12/52] sql: introduce mem_is_*() functions()

[Mergen Imeev]

Thank you for the review! My answer below.

On Thu, Apr 15, 2021 at 12:48:34AM +0200, Vladislav Shpilevoy wrote:
> Thanks for working on this!
> 
> > diff --git a/src/box/sql/mem.h b/src/box/sql/mem.h
> > index 82b3084fb..041d8a414 100644
> > --- a/src/box/sql/mem.h
> > +++ b/src/box/sql/mem.h
> > @@ -87,21 +87,6 @@ struct Mem {
> >   */
> >  #define MEMCELLSIZE offsetof(Mem,zMalloc)
> >  
> > -/**
> > - * Return a string that represent content of MEM. String is either allocated
> > - * using static_alloc() of just a static variable.
> > - */
> > -const char *
> > -mem_str(const struct Mem *mem);
> > -
> > -/** Initialize MEM and set NULL. */
> > -void
> > -mem_create(struct Mem *mem);
> > -
> > -/** Free all allocated memory in MEM and set MEM to NULL. */
> > -void
> > -mem_destroy(struct Mem *mem);
> 
> Why did you move them? They were just introduced in the previous
> commits.

Actually, I moved MEM_Flags since they should be defined before mem_is_*()
functions. Looks like for git moving these functions were more appropriate
solution.