[Tarantool-patches] [PATCH v2 4/9] box: make clear_synchro_queue() write a PROMOTE entry instead of CONFIRM + ROLLBACK

Cyrill Gorcunov gorcunov at gmail.com
Wed Apr 14 11:34:05 MSK 2021


On Wed, Apr 14, 2021 at 11:23:23AM +0300, Serge Petrenko wrote:
> > Is there some particular meaning of zeroifying designated assignments?
> > I mean why not simply
> > 
> > 			struct synchro_request req = {
> > 				.origin_id	= instance_id,
> > 				.lsn		= wait_lsn,
> > 			};
> > 
> > or you wanted to pay attention that the left of the fields are
> > unused? Just curious, I'm fine with current code.
> 
> I went for your option at first, and it's the one I'd prefer.
> But with it I got failed builds in some CI jobs.
> 
> It said something like "sorry, not yet implemented: struct partial
> initialization"

Ah, Serge, it is because of C++ compiler, not C. Sorry ;)


More information about the Tarantool-patches mailing list