[Tarantool-patches] [PATCH v5 37/52] sql: introduce mem_set_null_clear()

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Apr 13 02:38:18 MSK 2021


Nice fixes!

> diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c
> index 7f1e0bcbe..4566606d7 100644
> --- a/src/box/sql/vdbe.c
> +++ b/src/box/sql/vdbe.c
> @@ -855,7 +855,7 @@ case OP_String: {          /* out2 */
>   * is less than P2 (typically P3 is zero) then only register P2 is
>   * set to NULL.
>   *
> - * If the P1 value is non-zero, then also set the MEM_Cleared flag so that
> + * If the P1 value is non-zero, then also set the Cleared flag so that

The flag is still here. If you didn't remove it, I would propose to
keep its mentions in the comments.

>   * NULL values will not compare equal even if SQL_NULLEQ is set on
>   * OP_Ne or OP_Eq.
>   */


More information about the Tarantool-patches mailing list