[Tarantool-patches] [PATCH v2] qsync: provide box.info interface for monitoring

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Apr 8 22:37:54 MSK 2021


On 08.04.2021 09:11, Cyrill Gorcunov wrote:
> On Thu, Apr 08, 2021 at 12:52:48AM +0200, Vladislav Shpilevoy wrote:
>> On 07.04.2021 23:15, Cyrill Gorcunov wrote:
>>> On Wed, Apr 07, 2021 at 10:53:27PM +0200, Vladislav Shpilevoy wrote:
>>>> Hi! Thanks for the patch!
>>>>
>>>> See 7 comments below.
>>>>
>>>>>     qsync: provide box.info interface for monitoring
>>>>>     
>>>>>     Since commit 14fa5fd82 we support symbolic evaluation of
>>>>
>>>> 1. Please, after a commit hash provide the referenced commit
>>>> title in parentheses and quotes.
>>>> https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message
>>>
>>> Maybe worth to add an example then? Something like
>>
>> There is an example, see the link above.
> 
> There is a result example but no any hints on how to generate it. I added to the page
> an example of use `git log --pretty=format ...`.

You just do 'git show' on your hash and copy-paste the message.
I don't see anything hard in it.


More information about the Tarantool-patches mailing list