[Tarantool-patches] [PATCH v2 2/5] feedback_daemon: rename `send_test` to `send`
Serge Petrenko
sergepetrenko at tarantool.org
Thu Apr 8 16:38:38 MSK 2021
feedback_daemon.send() will come in handy once we implement triggers to
dispatch feedback after some events, for example, right on initial
instance configuration.
So, it's not a testing method anymore, hence the new name.
Part of #5750
---
src/box/lua/feedback_daemon.lua | 2 +-
test/box-tap/feedback_daemon.test.lua | 16 ++++++++--------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua
index 8820bcde5..d00eedf39 100644
--- a/src/box/lua/feedback_daemon.lua
+++ b/src/box/lua/feedback_daemon.lua
@@ -412,7 +412,7 @@ setmetatable(daemon, {
reload = function()
reload(daemon)
end,
- send_test = function()
+ send = function()
if daemon.control ~= nil then
daemon.control:put("send")
end
diff --git a/test/box-tap/feedback_daemon.test.lua b/test/box-tap/feedback_daemon.test.lua
index e1c450d2b..3d6bf1d9b 100755
--- a/test/box-tap/feedback_daemon.test.lua
+++ b/test/box-tap/feedback_daemon.test.lua
@@ -93,28 +93,28 @@ feedback_reset()
errinj.set("ERRINJ_HTTPC", false)
check('feedback received after errinj')
-daemon.send_test()
+daemon.send()
check("feedback received after explicit sending")
box.cfg{feedback_enabled = false}
feedback_reset()
-daemon.send_test()
+daemon.send()
test:ok(feedback_count == 0, "no feedback after disabling")
box.cfg{feedback_enabled = true}
-daemon.send_test()
+daemon.send()
check("feedback after start")
daemon.stop()
feedback_reset()
-daemon.send_test()
+daemon.send()
test:ok(feedback_count == 0, "no feedback after stop")
daemon.start()
-daemon.send_test()
+daemon.send()
check("feedback after start")
-daemon.send_test()
-check("feedback after feedback send_test")
+daemon.send()
+check("feedback after feedback send")
daemon.stop()
@@ -136,7 +136,7 @@ server:close()
-- check it does not fail without server
daemon = box.internal.feedback_daemon
daemon.start()
-daemon.send_test()
+daemon.send()
daemon.stop()
--
--
2.24.3 (Apple Git-128)
More information about the Tarantool-patches
mailing list