[Tarantool-patches] [PATCH v2 luajit 06/30] test: disable PUC Lua tests confused by -v output
Sergey Kaplun
skaplun at tarantool.org
Thu Apr 1 12:56:42 MSK 2021
Igor,
Thanks for the review!
On 01.04.21, Igor Munkin wrote:
> Sergey,
>
> Thanks for the patch! LGTM, except the nits below.
>
> On 26.03.21, Sergey Kaplun wrote:
> > Version and status are printed in stdout instead stderr since
>
> Typo: s/printed in stdout/printed to stdout/.
> Typo: s/instead stderr/instead of stderr/.
Fixed.
>
> > LuaJIT-2.0.0-beta11 (as it is not an error message).
> > See commit 0bd1a66f2f055211ef55834ccebca3b82d03c735
> > (Print version and JIT status to stdout, not stderr.).
> > This behavior is the same as in Lua 5.2.
> >
> > This patch disables tests confused by unexpected -v output to stdout.
> >
> > Relates to tarantool/tarantool#5687
> > Part of tarantool/tarantool#5845
> > Part of tarantool/tarantool#4473
> > ---
> > test/PUC-Lua-5.1-tests/main.lua | 28 ++++++++++++++++++++--------
> > 1 file changed, 20 insertions(+), 8 deletions(-)
> >
> > diff --git a/test/PUC-Lua-5.1-tests/main.lua b/test/PUC-Lua-5.1-tests/main.lua
> > index c11a576..56f56a0 100644
> > --- a/test/PUC-Lua-5.1-tests/main.lua
> > +++ b/test/PUC-Lua-5.1-tests/main.lua
> > @@ -103,26 +103,37 @@ prepfile[[
> > RUN("lua - < %s > %s", prog, out)
> > checkout("1\tnil\n")
> >
> > +-- Version and status are printed in stdout instead stderr since
> > +-- LuaJIT-2.0.0-beta11 (as it is not an error message).
>
> Typo: s/printed in stdout/printed to stdout/.
> Typo: s/instead stderr/instead of stderr/.
Fixed.
>
> > +-- See commit 0bd1a66f2f055211ef55834ccebca3b82d03c735
> > +-- (Print version and JIT status to stdout, not stderr.).
> > +-- This behavior is the same as in Lua 5.2.
> > +-- In Lua 5.2 this feature was introduced via commit
> > +-- 9e7de9473c65baee1f567852a778f2d33a47ea83.
> > +-- See also https://github.com/tarantool/tarantool/issues/5687.
>
> <snipped>
>
> > --
> > 2.31.0
> >
>
> --
> Best regards,
> IM
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list