[Tarantool-patches] [PATCH v2 1/2] fiber: introduce a callback for fibers switch-over

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Wed Sep 30 01:41:43 MSK 2020


Hi! Thanks for the patch!

> diff --git a/test/unit/CMakeLists.txt b/test/unit/CMakeLists.txt
> index 419477748..aace8cf50 100644
> --- a/test/unit/CMakeLists.txt
> +++ b/test/unit/CMakeLists.txt
> @@ -50,7 +50,7 @@ add_executable(bitset_index.test bitset_index.c)
>  target_link_libraries(bitset_index.test bitset)
>  add_executable(base64.test base64.c)
>  target_link_libraries(base64.test misc unit)
> -add_executable(uuid.test uuid.c)
> +add_executable(uuid.test uuid.c core_test_utils.c)

To make lib/core more self-sufficient we could make cord_on_yield
inlined in fiber.h under a macros like LIBCORE_USE_DEFAULT_ON_YIELD.
Which would be set by default to 1, but to 0 in the executable file.

Could help not to change the test binaries, and whatever else depends
on lib/core, but does not care about Lua.

I do not insist, but I will do that myself if someday I will need to
write a new unit test (raft, for example).


More information about the Tarantool-patches mailing list