[Tarantool-patches] [PATCH v2 0/2] Prevent JIT engine breakage on fibers switch-over

[Sergey Ostanevich]

Hi!

Thanks for the update, LGTM.

Sergos

On 28 сен 16:06, Igor Munkin wrote:
> Sergos,
> 
> Thanks for your review!
> 
> On 24.09.20, sergos at tarantool.org wrote:
> > Hi!
> > 
> > Thanks for the patch, please consider my 2 cents below.
> > 
> > Sergos
> > 
> > > On 23 Sep 2020, at 22:06, Igor Munkin <imun at tarantool.org> wrote:
> > > 
> 
> <snipped>
> 
> > > 
> > > @ChangeLog:
> > > * Fixed fibers switch-over to prevent JIT machinery misbehaviour. Trace
> > >  recording is aborted when fiber yields the execution. The yield
> > >  occuring while mcode is being run leads to the platform panic
> > 
> > Could you please rephrase the last sentence to be more clear, like
> > yielding from a function called directly from the jitted code (means -
> > through FFI) will cause panic.
> 
> I guess the following wording is quite close to the one you desire:
> 
> @ChangeLog:
> * Fixed fibers switch-over to prevent JIT machinery misbehaviour. Trace
>   recording is aborted when fiber yields the execution. The yield
>   occuring while the compiled code is being run (it's likely a function
>   with a yield underneath called via LuaJIT FFI) leads to the platform
>   panic (gh-1700, gh-4491).
> 
> > 
> > >  (gh-1700, gh-4491).
> > > 
> 
> <snipped>
> 
> > > 
> > > -- 
> > > 2.25.0
> > > 
> > 
> 
> -- 
> Best regards,
> IM