[Tarantool-patches] [PATCH v1 1/1] sql: remove OP_Realify
Nikita Pettik
korablev at tarantool.org
Mon Sep 28 18:55:59 MSK 2020
On 26 Sep 17:15, imeevma at tarantool.org wrote:
> This opcode was used to convert INTEGER values to REAL. It is not
> necessary in Tarantool and may cause errors.
Add justification: what this change fixes, in which way etc.
> Closes #5335
> ---
> https://github.com/tarantool/tarantool/issues/5335
> https://github.com/tarantool/tarantool/tree/imeevma/gh-5335-remove-op-realify
>
> @ChangeLog
> - Fixed a bug with unnecessary convertion from INTEGER to DOUBLE (gh-5335).
>
> src/box/sql/delete.c | 12 -----
> src/box/sql/expr.c | 13 -----
> src/box/sql/vdbe.c | 17 -------
> ...-unnecessary-conversation-to-double.result | 51 +++++++++++++++++++
> ...nnecessary-conversation-to-double.test.lua | 11 ++++
> 5 files changed, 62 insertions(+), 42 deletions(-)
> create mode 100644 test/sql/gh-5335-unnecessary-conversation-to-double.result
> create mode 100644 test/sql/gh-5335-unnecessary-conversation-to-double.test.lua
>
> diff --git a/src/box/sql/delete.c b/src/box/sql/delete.c
> index 68abd1f58..a78c68df6 100644
> --- a/src/box/sql/delete.c
> +++ b/src/box/sql/delete.c
> @@ -565,18 +565,6 @@ sql_generate_index_key(struct Parse *parse, struct index *index, int cursor,
> }
> uint32_t tabl_col = index->def->key_def->parts[j].fieldno;
> sqlVdbeAddOp3(v, OP_Column, cursor, tabl_col, reg_base + j);
> - /*
> - * If the column type is NUMBER but the number
> - * is an integer, then it might be stored in the
> - * table as an integer (using a compact
> - * representation) then converted to REAL by an
> - * OP_Realify opcode. But we are getting
> - * ready to store this value back into an index,
> - * where it should be converted by to INTEGER
> - * again. So omit the OP_Realify opcode if
> - * it is present
> - */
> - sqlVdbeDeletePriorOpcode(v, OP_Realify);
> }
> if (reg_out != 0)
> sqlVdbeAddOp3(v, OP_MakeRecord, reg_base, col_cnt, reg_out);
More information about the Tarantool-patches
mailing list