[Tarantool-patches] [PATCH v5 1/6] sql: remove unused DOUBLE to INTEGER conversion
Mergen Imeev
imeevma at tarantool.org
Mon Sep 28 18:50:37 MSK 2020
Hi! Thank you for the review. My answer below.
On Thu, Sep 17, 2020 at 02:48:08PM +0000, Nikita Pettik wrote:
> On 21 Aug 12:19, imeevma at tarantool.org wrote:
> > This patch removes the unused DOUBLE to INTEGER conversion from OP_Seek*
> > opcodes. This transformation is not used due to changes in the ApplyType
>
> What changes are..?
Changed commit-message a bit:
This patch removes the unused DOUBLE to INTEGER conversion from OP_Seek*
opcodes. This conversion is not used due to changes in the ApplyType
opcode after #3809. The next few patches will introduce new rules for
converting numbers (not just DOUBLE to INTEGER), and the implicit
conversion within the ApplyType opcode will be disabled for this case.
>
> > opcode. The next few patches will introduce new rules for converting
> > numbers (not just DOUBLE to INTEGER), and the implicit conversion within
> > the ApplyType opcode will be disabled for this case.
> >
> > Part of #4230
>
> LGTM
More information about the Tarantool-patches
mailing list