[Tarantool-patches] [PATCH v2 1/2] fiber: introduce a callback for fibers switch-over

[Igor Munkin]

Sergos,

Thanks for your review!

On 24.09.20, sergos at tarantool.org wrote:
> Hi!
> 
> Thank you for the patch, see my single comment below.
> 
> Regards,
> Sergos
> 
> > On 23 Sep 2020, at 22:06, Igor Munkin <imun at tarantool.org> wrote:
> > 

<snipped>

> > 
> > diff --git a/src/lib/core/fiber.c b/src/lib/core/fiber.c
> > index 483ae3ce1..1b7d255ff 100644
> > --- a/src/lib/core/fiber.c
> > +++ b/src/lib/core/fiber.c
> > @@ -46,6 +46,8 @@
> > #if ENABLE_FIBER_TOP
> > #include <x86intrin.h> /* __rdtscp() */
> > 
> 
> > +extern void cord_on_yield(void);
> > +
> 
> The definition is under ENABLE_FIBER_TOP, while its use isn’t. 
> The build will fail for ARM target for exmaple.
> AFAICS the changes are not releveant to the fiber top in any way.

Crap... Thanks for noticing! Fixed:

================================================================================

diff --git a/src/lib/core/fiber.c b/src/lib/core/fiber.c
index 1b7d255..223c841 100644
--- a/src/lib/core/fiber.c
+++ b/src/lib/core/fiber.c
@@ -43,11 +43,11 @@
 #include "trigger.h"
 #include "errinj.h"
 
+extern void cord_on_yield(void);
+
 #if ENABLE_FIBER_TOP
 #include <x86intrin.h> /* __rdtscp() */
 
-extern void cord_on_yield(void);
-
 static inline void
 clock_stat_add_delta(struct clock_stat *stat, uint64_t clock_delta)
 {

================================================================================

Side note: I guess we have to reprioritize ARM testing issue[1].

> 
> > static inline void
> > clock_stat_add_delta(struct clock_stat *stat, uint64_t clock_delta)
> > {

<snipped>

> > 
> 

[1]: https://github.com/tarantool/tarantool/issues/4270

-- 
Best regards,
IM