[Tarantool-patches] [PATCH v2] Add missed icu symbols
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Mon Sep 28 09:26:05 MSK 2020
On 28.09.2020 00:39, Alexandr Barulev wrote:
> Hello, thanks for the review of new patch version!
>
> I've fixed commit message (added `build` prefix) and rebased
> from master.
>
> I think commit, mentionied at patch message ("cmake: remove
> dynamic-list linker option") is related to #5266 issue.
> It's because symbols exports from required libs into tarantool binary
> earlier were configured with two options:
> by `--whole-archive` option;
> and `--dynamic-list,${exports_file}` option, where exports_file was created
> with use of mkexports script (symbols was grabbed by nm -D from shared
> libraries).
>
> Also, I've checkouted "cmake: remove dynamic-list linker option"
> commit, built static tarantool and ran icu-date tests. In result
> tests failed with `undefined symbol` errors.
> After that, I checkouted previous commit, built tarantool again
> and icu-date tests succeed
Ok, so this is because of whole-archive removal. Can it be fixed by
adding linking with the static ICU with whole-archive option instead of
manual exporting of each symbol, like it was before?
More information about the Tarantool-patches
mailing list