[Tarantool-patches] [PATCH v4 10/12] txm: use new tx manager in memtx

Aleksandr Lyapunov alyapunov at tarantool.org
Tue Sep 22 20:53:58 MSK 2020


Hi, thanks for the review.
Almost all if fixed, see my comment below:

On 15.09.2020 20:59, Nikita Pettik wrote:
>
>> diff --git a/src/box/vinyl.c b/src/box/vinyl.c
>> index aa6e50f..cee39c5 100644
>> --- a/src/box/vinyl.c
>> +++ b/src/box/vinyl.c
>> @@ -1076,7 +1076,7 @@ vinyl_space_check_format(struct space *space, struct tuple_format *format)
>>   		return -1;
>>   
>>   	/* See the comment in vinyl_space_build_index(). */
>> -	txn_can_yield(txn, true);
>> +	bool could_yield = txn_can_yield(txn, true);
> Don't get why vinyl related functions should be involved in this change..
> The rest is OK.
These vinyl functions are called in memtx transaction that performs 
alter of a vinyl space..
In the code vinyl changes behavior of the memtx transaction.



More information about the Tarantool-patches mailing list