[Tarantool-patches] [PATCH] coio: fix cord leak on stop

Cyrill Gorcunov gorcunov at gmail.com
Tue Sep 22 18:10:27 MSK 2020


On Tue, Sep 22, 2020 at 05:59:47PM +0300, Kirill Yukhin wrote:
> cord_ptr variable is calloc()-ated in coio_on_start()
> and is not free()-ed, which triggers ASAN. free() it
> in coio_on_stop().
> 
> Closes #5308
> ---
> 
> Branch: https://github.com/tarantool/tarantool/tree/kyukhin/gh-5308-cord-leak
> Issue: https://github.com/tarantool/tarantool/issues/5308
> ChangeLog: not user visible
> 
>  src/lib/core/coio_task.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/lib/core/coio_task.c b/src/lib/core/coio_task.c
> index 83f669d..c8be2de 100644
> --- a/src/lib/core/coio_task.c
> +++ b/src/lib/core/coio_task.c
> @@ -123,6 +123,7 @@ coio_on_stop(void *data)
>  {
>  	(void) data;
>  	cord_destroy(cord());
> +	free(cord());
>  	return 0;
>  }

Ack.


More information about the Tarantool-patches mailing list