[Tarantool-patches] [PATCH 0/3] lua/pwd: workaround the systemd bug

Kirill Yukhin kyukhin at tarantool.org
Fri Sep 18 15:26:29 MSK 2020


Hello,

On 17 сен 16:51, Cyrill Gorcunov wrote:
> Guys, take a look please once time permit. The first two patches
> are optional but I think while we're at this code and we could
> improve the code base we should.
> 
> Also I've been thinking on how to test the issue -- we need a buggy
> systemd instance running and we actually have Fedora 29 on gitlab
> where tests are passed but it is unclear for me how exactly we could
> use it. Initially I thought of injecting some error code into pwd module
> itself but then I left this idea of making code more ugly just because
> of some bug in the particular systemd version.
> 
> So my criteria was that the change must not break anything in existing
> tests but if you have some idea for testing, please share.
> 
> issue https://github.com/tarantool/tarantool/issues/5034
> branch gorcunov/gh-5034-passwd

LGTM.
I've checked your patch into 1.10, 2.4, 2.5 and master.

Could you please update release notes since I see no entry in cover letter.

--
Regards, Kirill Yukhin


More information about the Tarantool-patches mailing list