[Tarantool-patches] [PATCH v1] test: flaky replication/gh-5195-qsync-*

[Vladislav Shpilevoy]

>>> diff --git a/test/replication/gh-5195-qsync-replica-write.result b/test/replication/gh-5195-qsync-replica-write.result
>>> index 3999e8f5e..b47359fde 100644
>>> --- a/test/replication/gh-5195-qsync-replica-write.result
>>> +++ b/test/replication/gh-5195-qsync-replica-write.result
>>> @@ -96,10 +96,12 @@ test_run:wait_downstream(replica_id, {status='follow'})
>>>   | - true
>>>   | ...
>>>  test_run:wait_cond(function()                                                   \
>>> -        local info = box.info.replication[replica_id]                           \
>>> -        local lsn = info.downstream.vclock[replica_id]                          \
>>> -        return lsn and lsn >= replica_lsn                                       \
>>> -end)                                                                            \
>>> +        local lsn = box.info.replication[replica_id].downstream.vclock          \
>>
>> 3. It is not lsn, it is vclock now. Also I don't think you need to inline 'info'
>> variable, it was perfectly fine.
> 
> Right, the variable name was not correct - fixed. 'info' variable wasn't
> need to be set due to used only once.

That is not about number of usages. It is about code being easier to read
by avoiding too big one-liners.