[Tarantool-patches] [avtikhon at tarantool.org: Re: [PATCH v1] test: flaky replication/bootstrap_leader.test.lua]

[Alexander V. Tikhonov]

Hi Sergey, thanks for the review. This test uses build in timings which
were intially tunned for running on hosts without additional loads. But
running it on test hosts we use parallel mode for it and test cannot
pass in the given timings on which it depends to check needed statuses.
To give the test an ability to pass we need to add this test to fragile
list of test-run that sets its run without any other tests in parallel.

On Wed, Sep 09, 2020 at 06:51:13PM +0300, Serge Petrenko wrote:
> 
> 06.09.2020 23:06, Alexander V. Tikhonov пишет:
> > Found on heavy loaded hosts the issue:
> > 
> >    --- replication/bootstrap_leader.result	Wed Apr 15 15:47:41 2020
> >    +++ var/020_replication/bootstrap_leader.result	Sun Sep  6 21:57:40 2020
> >    @@ -52,10 +52,3 @@
> >         test_run:cmd("stop server replica"..i.." with cleanup=1")
> >         test_run:cmd("delete server replica"..i)
> >     end;
> >    - | ---
> >    - | ...
> >    -
> >    -test_run:cmd("setopt delimiter ''");
> >    - | ---
> >    - | - true
> >    - | ...
> > 
> > It happened, because the test used static timeouts, which on heavy
> > loaded hosts where not tuned for it. To fix the issue the test must
> > be run in standalone mode by test-run tool. To make it available the
> > test was added to 'fragile' list of its suite configuration file.
> > 
> > Closes #5275
> 
> 
> So what exactly  goes wrong here?
> Does  test_run itself  hang? Or do any of the replicas?
> 
> 
> > ---
> > 
> > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5275-flaky-bootstrap-leader
> > Issue: https://github.com/tarantool/tarantool/issues/5275
> > 
> >   test/replication/suite.ini | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/test/replication/suite.ini b/test/replication/suite.ini
> > index ab9c3dabd..be3f5b57e 100644
> > --- a/test/replication/suite.ini
> > +++ b/test/replication/suite.ini
> > @@ -24,3 +24,4 @@ fragile = errinj.test.lua            ; gh-3870
> >             gh-4605-empty-password.test.lua         ; gh-5030
> >             anon.test.lua              ; gh-5058
> >             status.test.lua            ; gh-5110
> > +          bootstrap_leader.test.lua  ; gh-5275
> 
> -- 
> Serge Petrenko
> 

----- End forwarded message -----