[Tarantool-patches] [PATCH v1] test: flaky replication/gh-4928-tx-boundaries test

Alexander V. Tikhonov avtikhon at tarantool.org
Sun Sep 6 18:36:51 MSK 2020


On heavy loaded hosts found the following issue:

  [089] --- replication/gh-4928-tx-boundaries.result	Wed Jul 29 04:08:29 2020
  [089] +++ replication/gh-4928-tx-boundaries.reject	Wed Jul 29 04:24:02 2020
  [089] @@ -94,7 +94,7 @@
  [089]   | ...
  [089]  box.info.replication[1].upstream.status
  [089]   | ---
  [089] - | - follow
  [089] + | - disconnected
  [089]   | ...
  [089]
  [089]  box.space.glob:select{}

It happened because replication upstream status check occurred too
early, when it was only in 'disconnected' state. To give the
replication status check routine ability to reach the needed 'follow'
state, it need to wait for it using test_run:wait_upstream() routine.

Closes #5234
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5234-fix-4928
Issue: https://github.com/tarantool/tarantool/issues/5234

 test/replication/gh-4928-tx-boundaries.result   | 4 ++--
 test/replication/gh-4928-tx-boundaries.test.lua | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/test/replication/gh-4928-tx-boundaries.result b/test/replication/gh-4928-tx-boundaries.result
index 969bd8438..4bd1b4b25 100644
--- a/test/replication/gh-4928-tx-boundaries.result
+++ b/test/replication/gh-4928-tx-boundaries.result
@@ -92,9 +92,9 @@ box.info.status
  | ---
  | - running
  | ...
-box.info.replication[1].upstream.status
+test_run:wait_upstream(1, {status = 'follow'})
  | ---
- | - follow
+ | - true
  | ...
 
 box.space.glob:select{}
diff --git a/test/replication/gh-4928-tx-boundaries.test.lua b/test/replication/gh-4928-tx-boundaries.test.lua
index 92526fc51..f245bff74 100644
--- a/test/replication/gh-4928-tx-boundaries.test.lua
+++ b/test/replication/gh-4928-tx-boundaries.test.lua
@@ -47,7 +47,7 @@ test_run:wait_vclock("replica", vclock)
 test_run:cmd('switch replica')
 
 box.info.status
-box.info.replication[1].upstream.status
+test_run:wait_upstream(1, {status = 'follow'})
 
 box.space.glob:select{}
 
-- 
2.17.1



More information about the Tarantool-patches mailing list