[Tarantool-patches] [PATCH v1 3/4] test: fix flaky vinyl/gh-4957-too-many-upserts

Alexander V. Tikhonov avtikhon at tarantool.org
Fri Oct 30 10:00:01 MSK 2020


Added restart the current server to resolve the issue #5141 which
reproduced in test:

  vinyl/gh-5141-invalid-vylog-file.test.lua

Added test-run filter on box.snapshot error message:

  'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'

to avoid of printing changing data in results file to be able to use
its checksums in fragile list of test-run to rerun it as flaky issue.

Part of #5141
---
 test/vinyl/gh-4957-too-many-upserts.result   | 17 +++++++++++++++++
 test/vinyl/gh-4957-too-many-upserts.test.lua | 11 +++++++++++
 2 files changed, 28 insertions(+)

diff --git a/test/vinyl/gh-4957-too-many-upserts.result b/test/vinyl/gh-4957-too-many-upserts.result
index 67292f0f8..c942e62c8 100644
--- a/test/vinyl/gh-4957-too-many-upserts.result
+++ b/test/vinyl/gh-4957-too-many-upserts.result
@@ -1,4 +1,13 @@
 -- test-run result file version 2
+test_run = require('test_run').new()
+ | ---
+ | ...
+test_run:cmd("push filter 'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'" .. \
+             "to 'Invalid VYLOG file: Slice <NUM> deleted but not registered'")
+ | ---
+ | - true
+ | ...
+
 s = box.schema.create_space('test', {engine = 'vinyl'})
  | ---
  | ...
@@ -90,3 +99,11 @@ fiber.sleep(0.01)
 s:drop()
  | ---
  | ...
+
+-- restart the current server to resolve the issue #5141
+-- which reproduced in test:
+--   vinyl/gh-5141-invalid-vylog-file.test.lua
+test_run:cmd("restart server default with cleanup=True")
+ | 
+
+
diff --git a/test/vinyl/gh-4957-too-many-upserts.test.lua b/test/vinyl/gh-4957-too-many-upserts.test.lua
index e5adfe41c..572540a4c 100644
--- a/test/vinyl/gh-4957-too-many-upserts.test.lua
+++ b/test/vinyl/gh-4957-too-many-upserts.test.lua
@@ -1,3 +1,7 @@
+test_run = require('test_run').new()
+test_run:cmd("push filter 'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'" .. \
+             "to 'Invalid VYLOG file: Slice <NUM> deleted but not registered'")
+
 s = box.schema.create_space('test', {engine = 'vinyl'})
 pk = s:create_index('pk')
 s:insert{1, 1}
@@ -36,3 +40,10 @@ box.snapshot()
 fiber.sleep(0.01)
 
 s:drop()
+
+-- restart the current server to resolve the issue #5141
+-- which reproduced in test:
+--   vinyl/gh-5141-invalid-vylog-file.test.lua
+test_run:cmd("restart server default with cleanup=True")
+
+
-- 
2.25.1



More information about the Tarantool-patches mailing list