[Tarantool-patches] [PATCH] lua: handle fiber cancellation for fiber.cond

[Alexander Turenko]

On Thu, Oct 29, 2020 at 08:14:37PM +0300, Sergey Ostanevich wrote:
> Hi Oleg!
> 
> Thanks for the comment, I believe I have to resend the patch along with
> C API changes.
> 
> What I see at the moment - failures like 
> 
> [076]  test_run:wait_upstream(1, {message_re = 'Missing %.xlog file',
> status = 'loading'})
> [076]  ---
> [076] -- true
> [076] +- false
> 
> which incurred by the intended behavior change, AFAIU. We no longer
> return 'true' in case the fiber is cancelled. The wait_upstream returns
> the cond wait result, hence the output differs.

It just a loop with sleeps. I don't see any relation to your change. If
the fail is stable, it should be the reason to investigate it.

If it is actually intended behaviour change (I doubt that it is so), you
should fix the test.