[Tarantool-patches] [PATCH 0/2] Minor fixes for new LuaJIT extention library

Alexander Turenko alexander.turenko at tarantool.org
Wed Oct 21 19:08:17 MSK 2020


LGTM from my side.

I don't see any problems in the patchset.

External Gentoo ebuild, Arch PKGBUILD, FreeBSD port do not list headers
to install explicitly (just like in-repo Debian rules).

https://github.com/tarantool/gentoo-overlay/blob/master/dev-db/tarantool/tarantool-9999.ebuild
https://github.com/archlinux/svntogit-community/blob/master/tarantool/trunk/PKGBUILD
https://svnweb.freebsd.org/ports/head/databases/tarantool/Makefile?view=markup

WBR, Alexander Turenko.

On Sat, Oct 17, 2020 at 02:13:29PM +0300, Sergey Kaplun wrote:
> This patchset consists from 2 parts:
> 1) Provide corresponding new LuaJIT header within tarantool at install.
> 2) Add missing public C API symbols from the new lib into exports.h
> 
> Branch: https://github.com/tarantool/tarantool/tree/skaplun/gh-5187-luajit-include-headers
> 
> CI is red, but fails related to replication tests or at osx_* jobs
> (see also https://github.com/tarantool/tarantool/issues/5423).
> CI: https://gitlab.com/tarantool/tarantool/-/pipelines/203892776
> 
> Sergey Kaplun (2):
>   build: provide missing LuaJIT lmisclib.h header
>   lua: add missing LuaJIT export symbols
> 
>  FreeBSD/databases/tarantool/pkg-plist | 1 +
>  cmake/luajit.cmake                    | 2 +-
>  rpm/tarantool.spec                    | 1 +
>  src/exports.h                         | 2 ++
>  4 files changed, 5 insertions(+), 1 deletion(-)
> 
> -- 
> 2.28.0
> 


More information about the Tarantool-patches mailing list