[Tarantool-patches] [PATCH v3] test: fix hanging of vinyl/[gh|iterator].test.lua

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Oct 20 23:46:48 MSK 2020


Hi! Thanks for the patch!

> diff --git a/test/vinyl/gh.result b/test/vinyl/gh.result
> index 0fd74af83..5f568e7b1 100644
> --- a/test/vinyl/gh.result
> +++ b/test/vinyl/gh.result
> @@ -7,7 +7,14 @@ env = require('test_run')
>  test_run = env.new()
>  ---
>  ...
> -fiber.sleep(1)
> +function box_snapshot()                                  \

It would be good to have a comment here explaining why the function exists.
Otherwise it may look unclear why would anyone wrap box.snapshot.

LGTM.


More information about the Tarantool-patches mailing list