[Tarantool-patches] [PATCH] module api: fix asan failures in test

Alexander V. Tikhonov avtikhon at tarantool.org
Fri Oct 16 20:17:29 MSK 2020


Hi Timur, thanks for the patch. As I see in results [1] it really fixed the
issue. Patch LGTM.

[1] - https://gitlab.com/tarantool/tarantool/-/jobs/795704534#L4636

On Fri, Oct 16, 2020 at 07:57:28PM +0300, Timur Safin wrote:
> Adding forgotten resource cleanup to the
> `test_tuple_validate_formatted` test, to make ASAN
> happy again.
> 
> Closes #5432
> Relates to #5384
> ---
> 
> Branch is tsafin/gh-5432-module-api-asan-fix
> 
>  test/app-tap/module_api.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/test/app-tap/module_api.c b/test/app-tap/module_api.c
> index 7ca0c9a15..ce7fa2353 100644
> --- a/test/app-tap/module_api.c
> +++ b/test/app-tap/module_api.c
> @@ -2327,6 +2327,8 @@ test_tuple_validate_formatted(lua_State *L)
>  		assert(format);
>  
>  		valid = box_tuple_validate(tuple, format) == 0;
> +		box_tuple_format_unref(format);
> +		box_key_def_delete(key_defs[0]);
>  	}
>  	lua_pushboolean(L, valid);
>  
> -- 
> 2.20.1
> 


More information about the Tarantool-patches mailing list