[Tarantool-patches] [PATCH] Remove hardcoded paths to LuaJIT tests

Timur Safin tsafin at tarantool.org
Fri Oct 16 15:33:17 MSK 2020


I could not resist and not highlight the fact that your patch "is not 
working" the same way as mine :)
https://gitlab.com/tarantool/tarantool/-/pipelines/203157106
(Or putting it the other way around - mine was working also. Being less 
intrusive as patch only for single repository, not 2)

LGTM, in any case, if you prefer 2 repo patch.

P.S.
I do not know whether it means anything, but apparently Debian-based 
Distros are green now, and RPM-based and others are red. Could it be 
there anything special which is Debian-specific?

: -----Original Message-----
: From: Igor Munkin <imun at tarantool.org>
: Sent: Friday, October 16, 2020 3:12 PM
: To: Alexander V. Tikhonov <avtikhon at tarantool.org>; Timur Safin
: <tsafin at tarantool.org>; Alexander Turenko
: <alexander.turenko at tarantool.org>
: Cc: Igor Munkin <imun at tarantool.org>; tarantool-patches at dev.tarantool.org
: Subject: [PATCH] Remove hardcoded paths to LuaJIT tests
: 
: As a result of the review[1] for Timur patch, I've finally got the idea
: how to reduce the struggling Kirill faces every time there is a new test
: created within LuaJIT third party repo. The series contains of two
: patches in both repos:
: * the root CMakeLists.txt for test directory is introduced to LuaJIT
:   repo in scope of the first patch
: * the paths in test/CMakeLists.txt are accordingly adjusted
: 
: Issue: https://github.com/tarantool/tarantool/issues/5425
: LuaJIT repo branches:
: * https://github.com/tarantool/luajit/tree/imun/gh-5425-luajit-tests-cmake
: * https://github.com/tarantool/luajit/tree/imun/gh-5425-luajit-tests-
: cmake-2.5
: Tarantool repo branch (need to be cherry-picked to all stable branches):
: * https://github.com/tarantool/tarantool/tree/imun/gh-5425-luajit-tests-
: cmake
: 
: CI is not green, but I've done my best. I see neither build fails nor
: failures related to the luajit-tap tests here:
: * https://gitlab.com/tarantool/tarantool/-/pipelines/203537445
: 
: [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-
: October/020266.html
: 
: --
: 2.25.0




More information about the Tarantool-patches mailing list