[Tarantool-patches] [PATCH v3 00/16] module api: extend for external key_def Lua module

Alexander Turenko alexander.turenko at tarantool.org
Fri Oct 16 09:05:52 MSK 2020


On Thu, Oct 15, 2020 at 04:19:58PM +0300, Alexander Turenko wrote:
> Updated.
> 
> Changes from v3 to the final version (I hope it is final):
> 
> - Fixed sorting of the box region functions in src/exports.h.
> - Added forgotten API_EXPORT for box_region_truncate().
> - Added a comment for luaT_tuple_encode_table() reference in the Lua registry.
> - Added the <size_t *key_size_ptr> parameter to box_key_def_validate_key() and
>   box_key_def_validate_full_key().
> - Fixed API comments for key_def functions with mention of the diagnostics
>   area.
> - Set a memory error to the diagnostics area for box_region_*alloc() functions.

List of changes that I made before pushing:

- test_iscdata(): fixed negative index testing:
  | - lua_pushboolean(L, res == exp);
  | + lua_pushboolean(L, ok);
- Found and fixed 'unused variable' warnings on module_api.c on
  RelWithDebInfo build.

Pushed to master, 2.5, 2.4 and 1.10.

Many thanks to Vlad for help with designing, eagle eyes and fast
responses.

WBR, Alexander Turenko.


More information about the Tarantool-patches mailing list