[Tarantool-patches] [PATCH 2.X v4 4/4] module api: box_ibuf_* wrappers

[Timur Safin]

: From: Alexander Turenko <alexander.turenko at tarantool.org>
: Subject: Re: [Tarantool-patches] [PATCH 2.X v4 4/4] module api: box_ibuf_*
: wrappers
: 
...
: >
: > +void
: > +box_ibuf_read_range(box_ibuf_t *ibuf, char ***rpos, char ***wpos)
: > +{
: > +       if (ibuf == NULL) {
: > +               diag_set(ClientError, ER_ILLEGAL_PARAMS,
: > +                        "Invalid ibuf argument");
: > +               return;
: > +       }
: > +       if (rpos != NULL)
: > +               *rpos = &ibuf->rpos;
: > +       if (wpos != NULL)
: > +               *wpos = &ibuf->wpos;
: > +}
: 
: You should return a code (0 / -1) so. The diagnostics area is like
: errno: a caller should lean on the code, not the diagnostics area to
: determine whether an error took place. If it occurs, then the
: diagnostics is guaranteed to exist and to be actual.

Indeed - wait a minute, will change.

Timur