[Tarantool-patches] [PATCH v1] gitlab-ci: add OSX 13 to testing

Igor Munkin imun at tarantool.org
Thu Oct 15 18:45:25 MSK 2020


Sasha,

Thanks for the patch! The changes are LGTM, except a single nit.

On 14.10.20, Alexander V. Tikhonov wrote:
> Restored OSX 13 testing to pass homebrew commit criteria.
> Added MACOSX_DEPLOYMENT_TARGET=10.13 environment.

Typo: s/environment/environment variable/.

Side note: it would be nice to describe the issue fixed by this variable
right in commit message, but I see the related info in the mentioned
ticket, so feel free to ignore.

> 
> Closes #5374
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/mac-13
> Issue: https://github.com/tarantool/tarantool/issues/5374
> 
>  .gitlab-ci.yml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

<snipped>

> -- 
> 2.25.1
> 

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list