[Tarantool-patches] [PATCH 2/2] test: disable jit related tests at FreeBSD

[Sergey Ostanevich]

Hi!

Thanks for the patch!

LGTM.

Sergos

On 15 окт 10:25, Sergey Kaplun wrote:
> Hi, Igor! Thanks for the review!
> 
> I've updated commit message considering your comments and repushed
> branch.
> 
> On 14.10.20, Igor Munkin wrote:
> > Sergey,
> > 
> > Thanks for the patch! It LGTM, but I can't stop nitpicking :)
> > 
> > On 14.10.20, Sergey Kaplun wrote:
> > > This patch fixes the regression introduced in scope of
> > > 5a61e1ab54b5c66bfebd836db1ac47996611e065 ('misc: add C and Lua API for
> > > platform metrics').
> > > 
> > > As far as newly added tests include trace checks and
> > > https://github.com/tarantool/tarantool/issues/4819 (JIT fails to
> > 
> > Minor: Let's be consistent in referring external issues:
> > | tarantool/tarantool#4819
> > 
> > > allocate mcode memory on FreeBSD) has not resolved yet, this tests
> > 
> > Typo: s/this/these/.
> > 
> > > should be disabled to for running on FreeBSD.
> > 
> > Typo: s/to for/while/.
> > 
> > > 
> > > Follows up tarantool/tarantool#5187
> > > ---
> > 
> > <snipped>
> > 
> > > -- 
> > > 2.28.0
> > > 
> > 
> > -- 
> > Best regards,
> > IM
> 
> -- 
> Best regards,
> Sergey Kaplun