[Tarantool-patches] [PATCH] luacheck: fixed warning in tarantoolctl.in
Alexander Turenko
alexander.turenko at tarantool.org
Thu Oct 15 02:04:37 MSK 2020
LGTM.
Pushed to master and 2.5.
WBR, Alexander Turenko.
On Wed, Oct 14, 2020 at 03:14:08PM +0300, Artem Starshov wrote:
> luacheck: fixed warning in tarantoolctl.in
Nit: Use imperative mood in a commit header, 'fix' instead of 'fixed'.
> Changed passing global variable arg to function
> find_instance_name(arg) instead of passing arg[0] and arg[2] separately.
> And removed exception in .luacheckrc for file /extra/dist/tarantoolctl.in.
Nit: Fit the commit message body to 72 symbols (at least for a prose
text, but not necessary for listings and so).
>
> This change only solves linter warning, nothing else.
>
> Fixed #4929.
The commit message on the branch is the previous one. Next time, please,
keep a branch in sync with patches you send to the mailing list.
More information about the Tarantool-patches
mailing list