[Tarantool-patches] [PATCH] feedback_daemon: add synchro replication usage reporting

[Serge Petrenko]

13.10.2020 17:01, Cyrill Gorcunov пишет:
> On Tue, Oct 13, 2020 at 04:34:18PM +0300, Serge Petrenko wrote:
>>   
>> +local function fill_in_options(feedback)
>> +    local options = {}
>> +    options.election_mode = box.cfg.election_mode
>> +    options.synchro_quorum = box.cfg.replication_synchro_quorum
>> +    feedback.options = options
>> +end
> Maybe be we could just get rid of local variable here?
Yes, sure. I'll do it together with other fixes, if any.
>
> local function fill_in_options(feedback)
>      feedback.options = {
>          ['election_mode']   = box.cfg.election_mode,
>          ['synchro_quorum']  = box.cfg.replication_synchro_quorum,
>      }
> end
>
> Not insisting at all just a thought.

-- 
Serge Petrenko